Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1777] Separate classloader for deployment managers #7335

Merged
merged 100 commits into from
Jan 21, 2025
Merged

[NU-1777] Separate classloader for deployment managers #7335

merged 100 commits into from
Jan 21, 2025

Conversation

coutoPL
Copy link
Member

@coutoPL coutoPL commented Dec 13, 2024 •
edited by mk-software-pl
Loading

Describe your changes

  • deployment managers have a separate class loader (the Application ClassLoader is no longer used to load their classe
  • deployment manager class loader is a parent for the model class loader
  • you can configure paths for deployment managers using the managersDirs config setting
  • removed unused env used at the SBT level (includeFlinkAndScala)
  • new E2E test (example R-R scenario)

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Dec 13, 2024
@github-actions github-actions bot added client client main fe ui labels Dec 14, 2024
@coutoPL coutoPL marked this pull request as ready for review December 16, 2024 08:58
arkadius
arkadius reviewed Dec 16, 2024
View reviewed changes
build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/description/NodesApiEndpoints.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/ModelData.scala Show resolved Hide resolved
build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@github-actions github-actions bot added client client main fe ui labels Jan 20, 2025
@github-actions github-actions bot removed ui client client main fe labels Jan 20, 2025
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Closed
@mk-software-pl mk-software-pl merged commit 942db11 into staging Jan 21, 2025
18 checks passed
@mk-software-pl mk-software-pl deleted the change/NU-1777 branch January 21, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-software-pl mk-software-pl mk-software-pl left review comments

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@coutoPL @arkadius @mk-software-pl @DeamonDev @paw787878 @JulianWielga @piotrp @Dzuming @philemone @lciolecki